From 3d36a443fb15e734736db230e7f1502784940887 Mon Sep 17 00:00:00 2001 From: Nattapon Wongpaet Date: Wed, 22 Aug 2018 16:14:03 +0700 Subject: [PATCH] add constant --- ais-structure/src/modules/customer/customer.ctrl.js | 13 +++++++------ ais-structure/src/modules/customer/postCustomer.ctrl.js | 11 ++++++----- ais-structure/src/modules/helper/constants.js | 32 ++++++++++++++++++++++++++++++++ ais-structure/src/modules/vizcard/vizCard.ctrl.js | 7 ++++--- 4 files changed, 49 insertions(+), 14 deletions(-) create mode 100644 ais-structure/src/modules/helper/constants.js diff --git a/ais-structure/src/modules/customer/customer.ctrl.js b/ais-structure/src/modules/customer/customer.ctrl.js index d9c2f7b..9f863f4 100644 --- a/ais-structure/src/modules/customer/customer.ctrl.js +++ b/ais-structure/src/modules/customer/customer.ctrl.js @@ -3,6 +3,7 @@ var validatorHelper = require('../helper/validator.js'); var connection = require('../helper/connection.js'); var responseMsg = require('../helper/responseMsg.js'); var log = require('../helper/log.js'); +var constant = require('../helper/constants.js') exports.customer = async function (req, res, next) { var getCmd = "Customer"; @@ -11,7 +12,7 @@ exports.customer = async function (req, res, next) { var d01 = "D01" log.startlog(getCmd,req); - log.logDetail.addInput(sacf,getCmd,"Request",req,req.body); + log.logDetail.addInput(sacf,getCmd,constant.REQUEST,req,req.body); var err = validator(req,getCmd); @@ -24,9 +25,9 @@ exports.customer = async function (req, res, next) { { var objectData = req.query; - const result = await connection.requestJsonToD01(objectData,sendCmd,"GET"); + const result = await connection.requestJsonToD01(objectData,sendCmd,constant.METHOD.GET); // console.log(Object.keys(result)) - log.logDetail.addInput(d01,sendCmd,"Response",result,result.response); + log.logDetail.addInput(d01,sendCmd,constant.RESPONSE,result,result.response); if(typeof result.err === 'undefined'){ // console.log(result.response); var resultObj = result.response; @@ -34,12 +35,12 @@ exports.customer = async function (req, res, next) { { if(resultObj.resultData && resultObj.resultData.length>0) { - stats.receiveRestResponse(d01,"GET",sendCmd,"Success"); + stats.receiveRestResponse(d01,constant.METHOD.GET,sendCmd,"Success"); var response = responseMsg.success(req,getCmd,resultObj); log.addSuccessSummary(d01,sendCmd,response); }else { - stats.receiveRestResponse(d01,"GET",sendCmd,"Data Not Found"); + stats.receiveRestResponse(d01,constant.METHOD.GET,sendCmd,"Data Not Found"); var response = responseMsg.error(req,getCmd,40300); log.addErrorSummary(d01,sendCmd,response); } @@ -55,7 +56,7 @@ exports.customer = async function (req, res, next) { stats.receiveResponse(sacf,sendCmd,"Error"); } - log.logDetail.addOutput(sacf,getCmd,"Response",response,response); + log.logDetail.addOutput(sacf,getCmd,constant.RESPONSE,response,response); res.status(200).json(response); next(); }; diff --git a/ais-structure/src/modules/customer/postCustomer.ctrl.js b/ais-structure/src/modules/customer/postCustomer.ctrl.js index 16b873e..8ee484a 100644 --- a/ais-structure/src/modules/customer/postCustomer.ctrl.js +++ b/ais-structure/src/modules/customer/postCustomer.ctrl.js @@ -3,6 +3,7 @@ var validatorHelper = require('../helper/validator.js'); var connection = require('../helper/connection.js'); var responseMsg = require('../helper/responseMsg.js'); var log = require('../helper/log.js'); +var constant = require('../helper/constants.js') exports.postCustomer = async function (req, res, next){ var getCmd = "Customer"; @@ -11,7 +12,7 @@ exports.postCustomer = async function (req, res, next){ var d01 = "D01"; log.startlog(getCmd,req); - log.logDetail.addInput(sacf,getCmd,"Request",req,req.body); + log.logDetail.addInput(sacf,getCmd,constant.REQUEST,req,req.body); var err = validator(req,getCmd); @@ -33,20 +34,20 @@ exports.postCustomer = async function (req, res, next){ }; const result = await connection.requestJsonToD01(objectData,sendCmd,"POST"); - log.logDetail.addInput(d01,sendCmd,"Response",result,result.response); + log.logDetail.addInput(d01,sendCmd,constant.RESPONSE,result,result.response); if(typeof result.err === 'undefined'){ // console.log(result.response.body); var resultObj = result.response; if(resultObj.resultCode.startsWith("2")) { - stats.receiveRestResponse(d01,"POST",sendCmd,"Success"); + stats.receiveRestResponse(d01,constant.METHOD.POST,sendCmd,"Success"); var response = responseMsg.direct(req,getCmd,resultObj,{customerId:objectData.customerId}); log.addSuccessSummary(d01,sendCmd,response); } else { if(resultObj.resultCode != "40401"){ resultObj.resultCode = "50000"; } - stats.receiveRestResponse(d01,"GET",sendCmd,"Error"); + stats.receiveRestResponse(d01,constant.METHOD.POST,sendCmd,"Error"); var response = responseMsg.direct(req,getCmd,resultObj); log.addErrorSummary(d01,sendCmd,response); } @@ -61,7 +62,7 @@ exports.postCustomer = async function (req, res, next){ stats.receiveResponse(sacf,sendCmd,"Error"); } - log.logDetail.addOutput(sacf,getCmd,"Response",response,response); + log.logDetail.addOutput(sacf,getCmd,constant.RESPONSE,response,response); res.status(200).json(response); next(); }; diff --git a/ais-structure/src/modules/helper/constants.js b/ais-structure/src/modules/helper/constants.js new file mode 100644 index 0000000..ba4a805 --- /dev/null +++ b/ais-structure/src/modules/helper/constants.js @@ -0,0 +1,32 @@ +module.exports = Object.freeze({ + REQUEST: 'Request', + RESPONSE: 'Response', + METHOD:{ + GET : 'GET', + POST : 'POST', + PUT : 'PUT', + DELETE : 'DELETE' + }, + RESPONSERESULT:{ + SUCCESS:{ + resultCode : '20000', + resultDescription : 'Success' + }, + MISSING_INVALID:{ + resultCode : '40300', + resultDescription : 'Missing or invalid parameter' + }, + DATA_NOT_FOUND:{ + resultCode : '40401', + resultDescription : 'Data Not Found' + }, + DATA_EXIST:{ + resultCode : '40301', + resultDescription : 'Data Exist' + }, + ERROR:{ + resultCode : '50000', + resultDescription : 'System error' + } + } +}); \ No newline at end of file diff --git a/ais-structure/src/modules/vizcard/vizCard.ctrl.js b/ais-structure/src/modules/vizcard/vizCard.ctrl.js index 512e6f4..3923af7 100644 --- a/ais-structure/src/modules/vizcard/vizCard.ctrl.js +++ b/ais-structure/src/modules/vizcard/vizCard.ctrl.js @@ -6,6 +6,7 @@ var validatorHelper = require('../helper/validator.js'); var connection = require('../helper/connection.js'); var responseMsg = require('../helper/responseMsg.js'); var log = require('../helper/log.js'); +var constant = require('../helper/constants.js') exports.vizcard = async function (req, res, next) { var getCmd = "VIZCard"; @@ -13,7 +14,7 @@ exports.vizcard = async function (req, res, next) { var sacf = "SACF" log.startlog(getCmd,req); - log.logDetail.addInput(sacf,getCmd,"Request",req,req.body); + log.logDetail.addInput(sacf,getCmd,constant.REQUEST,req,req.body); var err = validator(req,getCmd); @@ -70,14 +71,14 @@ exports.vizcard = async function (req, res, next) { var resultSet = {rawDataJson : ""} } - log.logDetail.addInput(sacf,sendCmd,"Response",result,resultSet.rawDataJson); + log.logDetail.addInput(sacf,sendCmd,constant.RESPONSE,result,resultSet.rawDataJson); if(!response){ var response = responseMsg.error(req,getCmd,50000); stats.receiveSACFResponse(sacf,sendCmd,"Error"); } - log.logDetail.addOutput(sacf,getCmd,"Response",response,response); + log.logDetail.addOutput(sacf,getCmd,constant.RESPONSE,response,response); res.status(200).json(response); next(); } -- libgit2 0.21.2